[base-compatibility-version] introduce SONiC base OS compatibility ve… #5936
Conversation
…rsion number Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
| @@ -452,6 +452,7 @@ sudo tee $FILESYSTEM_ROOT/etc/sonic/sonic_version.yml > /dev/null <<EOF | |||
| build_version: '${SONIC_IMAGE_VERSION}' | |||
| debian_version: '$(cat $FILESYSTEM_ROOT/etc/debian_version)' | |||
| kernel_version: '$kversion' | |||
| base_os_compatibility_version: ${BASE_OS_COMPATIBILITY_VERSION} | |||
There was a problem hiding this comment.
Is there a plan to display this detail as part of "show version" command output?
There was a problem hiding this comment.
Hi, yes, I'll share a PR soon
There was a problem hiding this comment.
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 5936 in repo Azure/sonic-buildimage |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| # SONiC packages dependning on specific SONiC base image features (kernel change, etc.) | ||
| # may define a dependency on specific version pattern. | ||
|
|
||
| BASE_OS_COMPATIBILITY_VERSION = 1.0.0 |
There was a problem hiding this comment.
What is the plan behind on update of this version ?
How is it mandated ?
W/o a plan in place, this will lose its value
For e.g. Image version is mandated, kernel version is picked.
There was a problem hiding this comment.
@yxieca, @lguohan, @ben-gale, @liat-grozovik -- We could start with these folks to get some answer.
@stepanblyschak -- Can you please drive this?
There was a problem hiding this comment.
@stepanblyschak Shouldn't this PR also include the mechanism that was discussed about how the versioning would be done and derived ? Would you capture it as an separate PR ?
|
@renukamanavalan @bandaru-viswanath Versioning guidelines were added to HLD https://github.com/Azure/SONiC/blob/b154820484fa297e4cb3a010c8f5709e891edc43/doc/sonic-application-extention/sonic-versioning-strategy.md. and updated based on discussion last week. |
|
Irrelevant according to latest update. Base OS components version is implemented in #6712 |
…rsion number
Signed-off-by: Stepan Blyshchak stepanb@nvidia.com
This PR is part of SONiC Application Extension
- Why I did it
To record SONiC version that follows semantic versioning spec.
- How I did it
Include a new entry in sonic_version.yml.
- How to verify it
Build an image and cat /etc/sonic/sonic_version.yml.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)