Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph] set admin_status to down if port not in minigraph #6865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[minigraph] set admin_status to down if port not in minigraph #6865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sonic-config-engine/minigraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,6 +1364,11 @@ def parse_xml(filename, platform=None, port_config_file=None, asic_name=None, hw
for port in ports.values():
port['pfc_asym'] = 'off'

# make admin status to down if port not parsed from minigraph
for port in ports.keys():
if 'admin_status' in ports[port] and port not in port_speeds_default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check if 'admin_status' in ports[port]. What would be the value if its present? Where is that default value coming from?

ports[port]['admin_status'] = 'down'

# set physical port default admin status up
for port in phyport_intfs:
if port[0] in ports:
Expand Down
Loading