[sonic-py-common.task_base] Provide ability to set stop timeouts #6914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Apr 8, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…ic-net#6914) #### Why I did it Allowing an application to set a stop timeout for processes and threads provides the following benefits: 1. Prevents the application from hanging indefinitely in the case a process or thread does not exit 2. Allow ProcessTaskBase a chance to let the process exit gracefully before attempting to kill it Default values are as follows: - ProcessTaskBase: 1 second - ThreadTaskBase: No timeout #### How I did it - Add optional `stop_timeout_secs` parameter to initializers of ProcessTaskBase and ThreadTaskBase - Additionally: - Prefix private attributes with an underscore - Remove obsolete comments
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…ic-net#6914) #### Why I did it Allowing an application to set a stop timeout for processes and threads provides the following benefits: 1. Prevents the application from hanging indefinitely in the case a process or thread does not exit 2. Allow ProcessTaskBase a chance to let the process exit gracefully before attempting to kill it Default values are as follows: - ProcessTaskBase: 1 second - ThreadTaskBase: No timeout #### How I did it - Add optional `stop_timeout_secs` parameter to initializers of ProcessTaskBase and ThreadTaskBase - Additionally: - Prefix private attributes with an underscore - Remove obsolete comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Allowing an application to set a stop timeout for processes and threads provides the following benefits:
Default values are as follows:
How I did it
stop_timeout_secsparameter to initializers of ProcessTaskBase and ThreadTaskBaseHow to verify it
Create concrete implementations of the classes and test the timeout functionality.
Which release branch to backport (provide reason below if selected)