Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Bug fix: Support dynamic buffer calculation for ACS-MSN3420 and ACS-MSN4410 #7113

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Mar 22, 2021

Why I did it

Add missed files for dynamic buffer calculation for ACS-MSN3420 and ACS-MSN4410

How I did it

  1. asic_table.j2: Add mapping from platform to ASIC
  2. Add buffer_dynamic.json.j2 for ACS-MSN4410.

How to verify it

Check whether the dynamic buffer calculation daemon starts successfully.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

…N4410

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@liat-grozovik
Copy link
Collaborator

In the last runs few tests are failing and none of them related to buffer change in this PR.

  • test_dhcp_relay_start_with_uplinks_down[single]
  • test_bgp_gr_helper_routes_perserved

@lguohan are those known and there is someone who is taking care of the test stability in master?

@liat-grozovik liat-grozovik requested review from neethajohn and removed request for jleveque March 30, 2021 13:34
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit 46a7fac into sonic-net:master Apr 7, 2021
yxieca pushed a commit that referenced this pull request Apr 8, 2021
…N4410 (#7113)

- Why I did it
Add missed files for dynamic buffer calculation for ACS-MSN3420 and ACS-MSN4410

- How I did it
asic_table.j2: Add mapping from platform to ASIC
Add buffer_dynamic.json.j2 for ACS-MSN4410.

- How to verify it
Check whether the dynamic buffer calculation daemon starts successfully.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs deleted the dynamic_buffer_4410_3420 branch April 10, 2021 10:53
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
…N4410 (sonic-net#7113)

- Why I did it
Add missed files for dynamic buffer calculation for ACS-MSN3420 and ACS-MSN4410

- How I did it
asic_table.j2: Add mapping from platform to ASIC
Add buffer_dynamic.json.j2 for ACS-MSN4410.

- How to verify it
Check whether the dynamic buffer calculation daemon starts successfully.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…N4410 (sonic-net#7113)

- Why I did it
Add missed files for dynamic buffer calculation for ACS-MSN3420 and ACS-MSN4410

- How I did it
asic_table.j2: Add mapping from platform to ASIC
Add buffer_dynamic.json.j2 for ACS-MSN4410.

- How to verify it
Check whether the dynamic buffer calculation daemon starts successfully.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants