build: Fix ARM build break introduced in PR# 7249 #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR# 7249 introduced a new bit of logic _after_ the point where the qemu based build environment for ARM is removed. Hence the new logic fails when building for ARM. Builds for AMD64 were not affected. This commit moves the new logic introduced by PR# 7249 to just _before_ the point where the qemu based build environment for ARM is removed. A comment is added to reduce the likelihood of this sort of ARM build break from happening again.
lguohan
approved these changes
Apr 21, 2021
|
Hi Guohan, Can we get this one backported to 202012 please? Thanks, |
lguohan
pushed a commit
that referenced
this pull request
Apr 28, 2021
PR# 7249 introduced a new bit of logic _after_ the point where the qemu based build environment for ARM is removed. Hence the new logic fails when building for ARM. Builds for AMD64 were not affected. This commit moves the new logic introduced by PR# 7249 to just _before_ the point where the qemu based build environment for ARM is removed. A comment is added to reduce the likelihood of this sort of ARM build break from happening again.
|
backported. |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
PR# 7249 introduced a new bit of logic _after_ the point where the qemu based build environment for ARM is removed. Hence the new logic fails when building for ARM. Builds for AMD64 were not affected. This commit moves the new logic introduced by PR# 7249 to just _before_ the point where the qemu based build environment for ARM is removed. A comment is added to reduce the likelihood of this sort of ARM build break from happening again.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
PR# 7249 introduced a new bit of logic _after_ the point where the qemu based build environment for ARM is removed. Hence the new logic fails when building for ARM. Builds for AMD64 were not affected. This commit moves the new logic introduced by PR# 7249 to just _before_ the point where the qemu based build environment for ARM is removed. A comment is added to reduce the likelihood of this sort of ARM build break from happening again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR# 7249 introduced a new bit of logic after the point where the qemu based
build environment for ARM is removed. Hence the new logic fails when building
for ARM. Builds for AMD64 were not affected.
This commit moves the new logic introduced by PR# 7249 to just before the
point where the qemu based build environment for ARM is removed. A comment is
added to reduce the likelihood of this sort of ARM build break from happening
again.
Why I did it
Fix armhf build error introduced by PR# 7249
How I did it
How to verify it
Build marvell-armhf image
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)