Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Arista] Chassis device configurations #7529

Merged
merged 21 commits into from
Jul 1, 2021
Merged

[Arista] Chassis device configurations #7529

merged 21 commits into from
Jul 1, 2021

Conversation

Staphylo
Copy link
Collaborator

@Staphylo Staphylo commented May 5, 2021

Add configurations for the following chassis elements

  • Fabrics 7804R3-FM, 7808R3-FM and 7808R3A-FM
  • Linecard 7800R3-48CQ2
  • Supervisor 7800-SUP*

@Staphylo Staphylo requested review from jleveque and lguohan as code owners May 5, 2021 19:07
@Staphylo
Copy link
Collaborator Author

Staphylo commented May 7, 2021

@anshuv-mfst for visibility

@Staphylo Staphylo force-pushed the master-chassis-configs branch from 6fa4fe2 to 14b0137 Compare May 19, 2021 00:19
@Staphylo
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@Staphylo Staphylo requested a review from judyjoseph May 19, 2021 19:17
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph
Copy link
Contributor

judyjoseph commented May 25, 2021 •
edited
Loading

For JR2 platforms, there is an additional change to enable the MSI interrupts while loading the bcm knet driver. Can you check if you need this ?

We can use the platform_env.conf to define the platform specific attributes. Following are references
https://github.com/judyjoseph/sonic-buildimage/blob/371833b266a5903a6358014b111e9588514ec5de/device/arista/x86_64-arista_7280cr3_32p4/platform_env.conf

https://github.com/Azure/sonic-buildimage/blob/master/platform/broadcom/saibcm-modules/debian/opennsl-modules.init#L52

@judyjoseph
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph
Copy link
Contributor

@eswaranb @ngoc-do to double check on the earlier comments shared.

@Staphylo Staphylo force-pushed the master-chassis-configs branch from 14b0137 to ffb1194 Compare June 17, 2021 12:41
@Staphylo
Copy link
Collaborator Author

Hi @judyjoseph, I was off for a while hence the late response.

For JR2 platforms, there is an additional change to enable the MSI interrupts while loading the bcm knet driver. Can you check if you need this ?

Looking at the settings used in our internal environment I believe we need to add the usemsi=1 parameters.
I went ahead and added the platform_env.conf to the chassis platforms (sup+fabrics & linecards).

@Staphylo Staphylo requested a review from judyjoseph June 18, 2021 07:47
@judyjoseph
Copy link
Contributor

judyjoseph commented Jun 18, 2021 •
edited
Loading

Hi @judyjoseph, I was off for a while hence the late response.

For JR2 platforms, there is an additional change to enable the MSI interrupts while loading the bcm knet driver. Can you check if you need this ?

Looking at the settings used in our internal environment I believe we need to add the usemsi=1 parameters.
I went ahead and added the platform_env.conf to the chassis platforms (sup+fabrics & linecards).

Please remove this setting "asic_type=bcm_dnx" from the platform_env.mk file ? This is not required anymore. We did this earlier where in the approach was a common broadcom image - but it is changed now to separate images. sonic-broadcom.bin for XGS ASIC family, sonic-broadcom-dnx.bin for DNXASIC family.

@Staphylo Staphylo force-pushed the master-chassis-configs branch from ffb1194 to 4f43838 Compare June 21, 2021 12:15
@Staphylo Staphylo force-pushed the master-chassis-configs branch 2 times, most recently from 29c7464 to 69f61c1 Compare June 22, 2021 14:37
@judyjoseph
Copy link
Contributor

@Staphylo could you resolve the conflicts as well.

ngoc-do and others added 14 commits June 25, 2021 02:44
@Staphylo Staphylo force-pushed the master-chassis-configs branch from 69f61c1 to 02d4ca3 Compare June 25, 2021 09:45
@Staphylo
Copy link
Collaborator Author

@Staphylo could you resolve the conflicts as well.

Done

@judyjoseph
Copy link
Contributor

@arlakshm could you take a look as well

arlakshm
arlakshm approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, lgtm

device/arista/x86_64-arista_7800_sup/Arista-7804R3-FM/10/port_config.ini Show resolved Hide resolved
@judyjoseph judyjoseph merged commit 17f0217 into sonic-net:master Jul 1, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@Staphylo
[Arista] Chassis device configurations (sonic-net#7529)
1a161da 
Add configurations for the following chassis elements

Fabrics 7804R3-FM, 7808R3-FM and 7808R3A-FM
Linecard 7800R3-48CQ2
Supervisor 7800-SUP*
@Staphylo Staphylo deleted the master-chassis-configs branch December 6, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@judyjoseph judyjoseph judyjoseph approved these changes

@arlakshm arlakshm arlakshm approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Included in 202106 Branch Request for 202106 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Staphylo @mssonicbld @judyjoseph @jleveque @arlakshm @Nakrez @ngoc-do @mlorrillere