-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DellEMC: S5248F - Platform API 2.0 implementation #7930
Conversation
This pull request introduces 20 alerts when merging 666dcca into 9d1c165 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix LGTM alerts
This pull request introduces 11 alerts when merging f995c2a into 5bf083a - view on LGTM.com new alerts:
|
This pull request introduces 10 alerts when merging cf42020 into 078e0e0 - view on LGTM.com new alerts:
|
Have addressed the LGTM alerts, the wrong name/number of the argument alerts are due to different platform definitions. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
platform/broadcom/sonic-platform-modules-dell/s5248f/scripts/s5248f_platform.sh
Outdated
Show resolved
Hide resolved
This pull request introduces 10 alerts when merging ae02384 into a3894b7 - view on LGTM.com new alerts:
|
This pull request introduces 10 alerts when merging 9ede79a into d6d7cb7 - view on LGTM.com new alerts:
|
This pull request introduces 10 alerts when merging 1948037 into d6d7cb7 - view on LGTM.com new alerts:
|
@joe, |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Have removed the python 2 support, can you review the latest changes and approve for merging. |
#### Why I did it Support API 2.0 for S5248F platform #### How I did it Making changes to S5248F platform specific directory Co-authored-by: Arun LK <Arun_L_K@dell.com>
#### Why I did it Support API 2.0 for S5248F platform #### How I did it Making changes to S5248F platform specific directory Co-authored-by: Arun LK <Arun_L_K@dell.com>
Why I did it
Support API 2.0 for S5248F platform
How I did it
Making changes to S5248F platform specific directory
How to verify it
With a python script verified the platform API return values.
Verified 'show platform' and 'show interface transceiver' related command outputs.
s5248f_UnitTest logs.txt
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)