-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libpci3 pkg to docker-platform-monitor #8016
Conversation
@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk? |
Done. |
Sorry, but I don't see it in the description. |
root@sonic:/var/log# dpkg-query -Wf '${Installed-Size}\t${Package}\n' | sort -n | grep libpci3
|
somehow the details are hidden in the html tags i guess. I have added it to the top section as well. |
Thanks. I have fixed the description here and in the other PRs. |
Thanks Joe. Really appreciate the quick response.
From: Joe LeVeque ***@***.***>
Date: Tuesday, June 29, 2021 at 11:39 AM
To: Azure/sonic-buildimage ***@***.***>
Cc: Venkat Garigipati (venkatg) ***@***.***>, Mention ***@***.***>
Subject: Re: [Azure/sonic-buildimage] add libpci3 pkg to docker-platform-monitor (#8016)
@VenkatCisco<https://github.com/VenkatCisco>: In the PR description, can you please indicate the installed size of this package on disk?
Done.
Sorry, but I don't see it in the description.
somehow the details are hidden in the html tags i guess. I have added it to the top section as well.
Thanks. I have fixed the description here and in the other PRs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#8016 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASPBHRV3RTU7N2X5AEARTVDTVIHMPANCNFSM47QNNTHA>.
|
@VenkatCisco: Is it necessary to backport this to the 201911 branch? That branch is relatively stable; we only want to backport bug fixes. |
I updated the PR to reflect it. Our Primary development branch is 202012 and Azure/master. |
#### Why I did it The libpci library provides portable access to configuration registers of devices connected to the PCI bus. #### How I did it update dockers/docker-platform-monitor/Dockerfile.j2
#### Why I did it The libpci library provides portable access to configuration registers of devices connected to the PCI bus. #### How I did it update dockers/docker-platform-monitor/Dockerfile.j2
Why I did it
The libpci library provides portable access to configuration registers of devices connected to the PCI bus.
How I did it
update dockers/docker-platform-monitor/Dockerfile.j2. Total usage is:
root@sonic:/var/log# dpkg-query -Wf '${Installed-Size}\t${Package}\n' | sort -n | grep libpci3
102 libpci3
How to verify it
Verify PCI based devices are mounted successfully on the PCI bus
Which release branch to backport (provide reason below if selected)
Description for the changelog
The libpci library provides portable access to configuration registers of devices connected to the PCI bus.
A picture of a cute animal (not mandatory but encouraged)