Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libpci3 pkg to docker-platform-monitor #8016

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

VenkatCisco
Copy link
Contributor

@VenkatCisco VenkatCisco commented Jun 29, 2021

Why I did it

The libpci library provides portable access to configuration registers of devices connected to the PCI bus.

How I did it

update dockers/docker-platform-monitor/Dockerfile.j2. Total usage is:

root@sonic:/var/log# dpkg-query -Wf '${Installed-Size}\t${Package}\n' | sort -n | grep libpci3
102 libpci3

How to verify it

Verify PCI based devices are mounted successfully on the PCI bus

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

The libpci library provides portable access to configuration registers of devices connected to the PCI bus.

root@sonic:/home/admin# dpkg-query -Wf '${Installed-Size}\t${Package}\n' | sort -n | grep libpci3
102     libpci3

A picture of a cute animal (not mandatory but encouraged)

@VenkatCisco VenkatCisco requested a review from lguohan as a code owner June 29, 2021 15:41
@jleveque
Copy link
Contributor

@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk?

@VenkatCisco
Copy link
Contributor Author

@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk?

Done.

@jleveque
Copy link
Contributor

@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk?

Done.

Sorry, but I don't see it in the description.

@VenkatCisco
Copy link
Contributor Author

VenkatCisco commented Jun 29, 2021

Why I did it

The libpci library provides portable access to configuration registers of devices connected to the PCI bus.

root@sonic:/var/log# dpkg-query -Wf '${Installed-Size}\t${Package}\n' | sort -n | grep libpci3
102 libpci3

How I did it

update dockers/docker-platform-monitor/Dockerfile.j2

How to verify it

Verify PCI based devices are mounted successfully on the PCI bus

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@VenkatCisco
Copy link
Contributor Author

@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk?

Done.

Sorry, but I don't see it in the description.

somehow the details are hidden in the html tags i guess. I have added it to the top section as well.

@jleveque
Copy link
Contributor

@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk?

Done.

Sorry, but I don't see it in the description.

somehow the details are hidden in the html tags i guess. I have added it to the top section as well.

Thanks. I have fixed the description here and in the other PRs.

@VenkatCisco
Copy link
Contributor Author

VenkatCisco commented Jun 29, 2021 via email

@jleveque
Copy link
Contributor

@VenkatCisco: Is it necessary to backport this to the 201911 branch? That branch is relatively stable; we only want to backport bug fixes.

@VenkatCisco
Copy link
Contributor Author

@VenkatCisco: Is it necessary to backport this to the 201911 branch? That branch is relatively stable; we only want to backport bug fixes.

I updated the PR to reflect it. Our Primary development branch is 202012 and Azure/master.

@jleveque jleveque changed the title add libpci3 pkg to docker-platform-monitor Add libpci3 pkg to docker-platform-monitor Jun 30, 2021
@jleveque jleveque merged commit c5855eb into sonic-net:master Jun 30, 2021
qiluo-msft pushed a commit that referenced this pull request Jul 7, 2021
#### Why I did it
The libpci library provides portable access to configuration registers of devices connected to the PCI bus.

#### How I did it
update dockers/docker-platform-monitor/Dockerfile.j2
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
#### Why I did it
The libpci library provides portable access to configuration registers of devices connected to the PCI bus.

#### How I did it
update dockers/docker-platform-monitor/Dockerfile.j2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants