Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service mark_dhcp_packet to mux container #9015

Merged
3 commits merged into from
Oct 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2021

  • add a new service "mark_dhcp_packet" to mux container
  • apply packet marks on a per-interface basis in ebtables
  • write packet marks to "DHCP_PACKET_MARK" table in state_db

Example:
INPUT chain in ebtables:
ebtables

DHCP_PACKET_MARK in state_db:
state_db

@ghost ghost requested a review from lguohan as a code owner October 20, 2021 04:05
@ghost ghost requested a review from prsunny October 20, 2021 04:06
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2021

This pull request introduces 3 alerts when merging c04650d into 14aca81 - view on LGTM.com

new alerts:

  • 3 for Unused import

files/scripts/mark_dhcp_packet.py Outdated Show resolved Hide resolved
files/scripts/mark_dhcp_packet.py Show resolved Hide resolved
@ghost ghost requested a review from prsunny October 22, 2021 00:02
@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2021

This pull request introduces 3 alerts when merging 5cd3374 into 861e878 - view on LGTM.com

new alerts:

  • 3 for Unused import

@ghost ghost merged commit 4e0c4fb into sonic-net:master Oct 26, 2021
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

ghost pushed a commit that referenced this pull request Nov 2, 2021
- update DHCP_PACKET_MARK schema in state_db
- this is an update over PR: Add service mark_dhcp_packet to mux container #9015
@ghost
Copy link
Author

ghost commented Nov 8, 2021

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

I don't see mux docker template file in 202012. Please solve that problem first. "mark_dhcp_packet" is a service inside mux container.

@ghost
Copy link
Author

ghost commented Nov 12, 2021

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

Please check if this pr now can be cherry-picked. If not, I will submit another.

qiluo-msft pushed a commit that referenced this pull request Nov 15, 2021
- add a new service "mark_dhcp_packet" to mux container
- apply packet marks on a per-interface basis in ebtables
- write packet marks to "DHCP_PACKET_MARK" table in state_db
qiluo-msft pushed a commit that referenced this pull request Nov 15, 2021
- update DHCP_PACKET_MARK schema in state_db
- this is an update over PR: Add service mark_dhcp_packet to mux container #9015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants