Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AS4630-54PE] Fix led drv and i2c bus order #9170

Merged
merged 6 commits into from
Mar 5, 2022

Conversation

jostar-yang
Copy link
Contributor

@jostar-yang jostar-yang commented Nov 4, 2021

Signed-off-by: Jostar Yang jostar_yang@accton.com.tw

Why I did it

  1. Fix led drv because CPLD SPEC is updated.
  2. Fix i2c bus order

How I did it

Fix led drv. Set blacklist to i801 and ismt. Let accton util to modprobe i801 and ismt.

How to verify it

Test led and sensors cmd. Results are fine.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
    --> Please merge code to this branch. Some customers need it

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
@jostar-yang jostar-yang requested a review from lguohan as a code owner November 4, 2021 08:26
@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2021

This pull request fixes 1 alert when merging e3f266f into ea91a72 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2021

This pull request fixes 1 alert when merging eeec97a into 2d7840c - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2021

This pull request fixes 1 alert when merging 16bd234 into 07de6a3 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Copy link

@akenliu akenliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About FAN-CPLD registers are changed, could you add more comment for which CPLD version needs this new modification.

@jostar-yang jostar-yang closed this Dec 9, 2021
@jostar-yang jostar-yang reopened this Dec 9, 2021
@jostar-yang
Copy link
Contributor Author

Check with HW RD and LED modified start from R01 board.

@jostar-yang
Copy link
Contributor Author

CPLD SPEC is updated for LED. So modify some led code. CPLD firmware is not changed for these LED part.

akenliu
akenliu previously approved these changes Dec 14, 2021
Copy link

@akenliu akenliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it is only changed the description in the CPLD document/spec and you modify code for this.
No need to upgrade CPLD firmware.
OK, thanks.

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2021

This pull request fixes 1 alert when merging 29b3348 into faab7d5 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@seanwu-ec seanwu-ec mentioned this pull request Dec 28, 2021
5 tasks
@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2021

This pull request fixes 1 alert when merging 7bf5e38 into 13582aa - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2022

This pull request fixes 1 alert when merging 630532a into f136c53 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@sujinmkang sujinmkang merged commit d959c4a into sonic-net:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants