-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AS4630-54PE] Fix led drv and i2c bus order #9170
[AS4630-54PE] Fix led drv and i2c bus order #9170
Conversation
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
This pull request fixes 1 alert when merging e3f266f into ea91a72 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging eeec97a into 2d7840c - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 16bd234 into 07de6a3 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About FAN-CPLD registers are changed, could you add more comment for which CPLD version needs this new modification.
Check with HW RD and LED modified start from R01 board. |
CPLD SPEC is updated for LED. So modify some led code. CPLD firmware is not changed for these LED part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it is only changed the description in the CPLD document/spec and you modify code for this.
No need to upgrade CPLD firmware.
OK, thanks.
This pull request fixes 1 alert when merging 29b3348 into faab7d5 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 7bf5e38 into 13582aa - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 630532a into f136c53 - view on LGTM.com fixed alerts:
|
Signed-off-by: Jostar Yang jostar_yang@accton.com.tw
Why I did it
How I did it
Fix led drv. Set blacklist to i801 and ismt. Let accton util to modprobe i801 and ismt.
How to verify it
Test led and sensors cmd. Results are fine.
Which release branch to backport (provide reason below if selected)
--> Please merge code to this branch. Some customers need it
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)