Update sonic-qsfp-monitor #9737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why I did it Missing syslog for transceiver inserted/removed event How I did it Add syslog (priority:info) for transceiver inserted and removed How to verify it Testing with transceiver insert and remove in SONiC runtime and check the syslog message Which release branch to backport (provide reason below if selected) 201911
prgeor
reviewed
Jan 15, 2022
Comment on lines
+277
to
+289
|
|
||
| pre_present=$(cat $cpld_path"module_present_"$i | awk '{printf $1}') | ||
| if [ $is_presence -eq 0 ];then | ||
| if [ $pre_present -eq 0 ];then | ||
| ethid=`expr $idx \* 8` | ||
| logger -i -t sonic-qsfp-monitor "Ethernet$ethid: Transceiver is inserted" --priority user.info | ||
| fi | ||
| else | ||
| if [ $pre_present -eq 1 ];then | ||
| ethid=`expr $idx \* 8` | ||
| logger -i -t sonic-qsfp-monitor "Ethernet$ethid: Transceiver is removed" --priority user.info | ||
| fi | ||
| fi |
There was a problem hiding this comment.
xcvrd already monitors for presence of qsfp. why is this separate monitoring used in your platform?
There was a problem hiding this comment.
Our platform has a BMC module to collect all platform information, so we use this task to do transceiver data polling from BMC and pass those data to SONiC platform driver. Then xcvrd can read transceiver data from platform driver to do it's work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Missing syslog for transceiver inserted/removed event
How I did it
Add syslog (priority:info) for transceiver inserted and removed
How to verify it
Testing with transceiver insert and remove in SONiC runtime and check the syslog message
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)