Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traceback issue when running caclmgrd #9836

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix traceback issue when running caclmgrd #9836

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8576eb6
Fix the issue of uncleaned cacl rules if there are multiple cacl tabl…
ZhaohuiS Jan 24, 2022
401530f
miss the scenario when acl_source_ip_map is empty
ZhaohuiS Jan 25, 2022
46cba61
Only fix traceback issue
ZhaohuiS Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sonic-host-services/scripts/caclmgrd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,8 @@ class ControlPlaneAclManager(daemon_base.DaemonBase):
for acl_service in self.ACL_SERVICES:
if self.ACL_SERVICES[acl_service]["multi_asic_ns_to_host_fwd"]:
# Get the Source IP Set if exists else use default source ip prefix
if acl_source_ip_map and acl_service not in acl_source_ip_map:
continue
nat_source_ipv4_set = acl_source_ip_map[acl_service]["ipv4"] if acl_source_ip_map and acl_source_ip_map[acl_service]["ipv4"] else { "0.0.0.0/0" }
nat_source_ipv6_set = acl_source_ip_map[acl_service]["ipv6"] if acl_source_ip_map and acl_source_ip_map[acl_service]["ipv6"] else { "::/0" }

Expand Down