Add new libswsscommon dependency in lgtm #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiarcot895
reviewed
Aug 12, 2022
| @@ -13,6 +13,9 @@ extraction: | |||
| - "libgmock-dev" | |||
| - "dh-exec" | |||
| - "swig3.0" | |||
| - "uuid-dev" | |||
| - "libzmq5" | |||
There was a problem hiding this comment.
Can you remove this one? libzmq3-dev will bring in libzmq5 automatically, and in case there's some ABI change and the package name changes, it's one less thing to update here.
saiarcot895
approved these changes
Aug 12, 2022
kellyyeh
added a commit
to kellyyeh/sonic-dhcp-relay
that referenced
this pull request
Aug 16, 2022
* Add new libswsscommon dependency Add uuid-dev, libzmq3-dev in lgtm.yml * Update lgtm.yml
kellyyeh
added a commit
to kellyyeh/sonic-dhcp-relay
that referenced
this pull request
Aug 22, 2022
* Add new libswsscommon dependency Add uuid-dev, libzmq3-dev in lgtm.yml * Update lgtm.yml
kellyyeh
added a commit
to kellyyeh/sonic-dhcp-relay
that referenced
this pull request
Oct 8, 2022
* Add new libswsscommon dependency Add uuid-dev, libzmq3-dev in lgtm.yml * Update lgtm.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add uuid-dev, libzmq5 in lgtm.yml