Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new repo sonic-gmni #1

Closed
wants to merge 61 commits into from
Closed

Use new repo sonic-gmni #1

wants to merge 61 commits into from

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented May 31, 2022 •
edited
Loading

Signed-off-by: Gang Lv ganglv@microsoft.com

HLD:
sonic-net/SONiC#996

ganglyu added 2 commits May 31, 2022 09:33
@ganglyu
first commit
48cacf2
@ganglyu
Use new repo sonic-gmni
2d104d7 
Signed-off-by: Gang Lv ganglv@microsoft.com
@ganglyu ganglyu requested review from lguohan and qiluo-msft May 31, 2022 02:09
@ganglyu ganglyu mentioned this pull request Jun 2, 2022
Merged
@lguohan
Copy link
Contributor

lguohan commented Jun 2, 2022

we need to setup lgtm as well as azp for this.

@lguohan
Copy link
Contributor

lguohan commented Jun 2, 2022

is there a design doc, can you add a link in the pr description?

what is the area you want to us to focus on? obviously it is a huge pr.

@ganglyu ganglyu closed this Jun 6, 2022
@ganglyu ganglyu reopened this Jun 6, 2022
@qiluo-msft
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2022

This pull request introduces 1 alert when merging 555c52b into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request introduces 1 alert when merging 43b8300 into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request introduces 1 alert when merging 5675b44 into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request introduces 1 alert when merging 482bc36 into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2022

This pull request introduces 1 alert when merging 1fffa3d into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2022

This pull request introduces 1 alert when merging 25c057d into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2022

This pull request introduces 1 alert when merging 46ae5b1 into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

qiluo-msft
qiluo-msft reviewed Jun 17, 2022
View reviewed changes
Makefile Outdated
sudo mkdir -p ${DBDIR}
sudo cp ./testdata/database_config.json ${DBDIR}
endif
cd ./gnmi_server && sudo $(GO) test -coverprofile=coverage-gnmi.txt -covermode=atomic -mod=vendor -coverpkg ./,../sonic_data_client
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./,../sonic_data_client

Limit coverage in some folders will not make sense in long run because we care about PR diff coverage, and it may hide some lines in hidden folders.

We could override this checker for the initial commits in this PR.

qiluo-msft
qiluo-msft reviewed Jun 17, 2022
View reviewed changes
debian/changelog Outdated

* Initial release.

-- Jipan Yang <jipan.yang@alibaba-inc.com> Sat, 24 Mar 2018 12:48:22 -0700
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not updated.

qiluo-msft
qiluo-msft reviewed Jun 17, 2022
View reviewed changes
debian/control Outdated
Source: sonic-gnmi
Section: devel
Priority: optional
Maintainer: Jipan Yang <jipan.yang@alibaba-inc.com>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer

The same

qiluo-msft
qiluo-msft reviewed Jun 17, 2022
View reviewed changes
debian/control Outdated
Priority: optional
Maintainer: Jipan Yang <jipan.yang@alibaba-inc.com>
Build-Depends: debhelper (>= 8.0.0),
Standards-Version: 3.9.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9.3

Is it the version of self package?

qiluo-msft
qiluo-msft reviewed Jun 17, 2022
View reviewed changes
Makefile Outdated

sonic-gnmi: $(GO_DEPS)
ifeq ($(CROSS_BUILD_ENVIRON),y)
$(GO) build -o ${GOBIN}/telemetry -mod=vendor $(BLD_FLAGS) github.com/sonic-net/sonic-gnmi/telemetry
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

telemetry

remove it?

qiluo-msft
qiluo-msft reviewed Jun 17, 2022
View reviewed changes
gnmi_dump/gnmi_dump.go Outdated
"github.com/sonic-net/sonic-gnmi/common_utils"
)

func main() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main

If this is a new CLI, add usage(). Normally we require file level and function level comments, usage is also kind of comments.

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2022

This pull request introduces 1 alert when merging 6e33aa1 into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2022

This pull request introduces 1 alert when merging ff851d9 into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2022

This pull request introduces 1 alert when merging 577bb9a into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2022

This pull request introduces 1 alert when merging 6356f5d into b8e2fc4 - view on LGTM.com

new alerts:

  • 1 for Use of insecure HostKeyCallback implementation

@ganglyu ganglyu closed this Jun 18, 2022
renukamanavalan added a commit that referenced this pull request Oct 6, 2022
@renukamanavalan
Merge pull request #1 from renukamanavalan/statistics
9a9f37f 
Statistics -- update added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft left review comments

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganglyu @lguohan @qiluo-msft