Added code to process-reboot-check that mitigates JSON decoder errors #126
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assrinivasan
changed the title
yxieca
approved these changes
May 17, 2024
prgeor
approved these changes
May 17, 2024
|
We also need this for 202205 which T2 chassis is still actively using the branch and need this bug fix. |
|
hi @yxieca should cherry pick this? |
mssonicbld
pushed a commit
to mssonicbld/sonic-host-services
that referenced
this pull request
Aug 15, 2024
|
Cherry-pick PR to 202311: #146 |
Yes. Let's take it to 202305 as well. |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 15, 2024
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-host-services
that referenced
this pull request
Aug 15, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-host-services
that referenced
this pull request
Aug 15, 2024
|
Cherry-pick PR to 202205: #147 |
|
Cherry-pick PR to 202305: #148 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 15, 2024
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Aug 15, 2024
mssonicbld
added
Included in 202205 Branch
and removed
Created PR to 202205 Branch
labels
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The current process-reboot-cause script is susceptible to JSONDecodeErrors if the reboot-cause file is not a properly formatted JSON file.
Fixes sonic-net/sonic-buildimage#18898
How I did it
Added a try-except block around the actual JSON parsing bit of the code
Microsoft ADO: 28062468
How I verified it
First I verified that the issue is seen when the reboot-cause file is either an empty file or an improperly formatted JSON file:
I then replaced the existing script with the script from this PR and restarted the service:
As is seen, the service exited with
SUCCESSexit code and journalctl shows the JSON Decoder exception raised when trying to parse an improper JSON file.