kdump-remote feature in hostcfgd #166
Conversation
|
This PR is related to or dependent on sonic-net/SONiC#1714. |
|
@venkatmahalingam Hi! we have updated the code. Please Help us review the Code PRs. Thanks |
|
@venkatmahalingam Hi! we have updated the code. Please Help us review the Code PRs. Thanks in advance , target is 202411 |
| @@ -1147,7 +1152,7 @@ class KdumpCfg(object): | |||
| for row in self.kdump_defaults: | |||
| value = self.kdump_defaults.get(row) | |||
| if not kdump_conf.get(row): | |||
| self.config_db.mod_entry("KDUMP", "config", {row : value}) | |||
There was a problem hiding this comment.
This change is still there, it is not removed. Added Detail for remote configs here in kdump table
scripts/hostcfgd
Outdated
| ssh_path = self.kdump_defaults["SSH_PATH"] | ||
| if data.get("SSH_PATH") is not None: | ||
| ssh_path = data.get("SSH_PATH") | ||
| run_cmd(["sonic-kdump-config", "--ssh_path", ssh_path]) |
There was a problem hiding this comment.
Why should we execute run_cmd with following defaults when KDUMP remote is not desired by the user?
SSH_KEY": "user@server", # New feature: SSH key, default value
"SSH_PATH": ""
There was a problem hiding this comment.
Hi @venkatmahalingam i have update the code as suggested above .
|
Hi @venkatmahalingam , please help merge this PR. Regards |
|
Hi @qiluo-msft PR has been reviewed by the reviewer with all checks passed, please help merge this. |
|
@qiluo-msft help merge this PR, pending for long |
|
Can we merge this PR? Thanks. |
we wantwant to add three new features to the KDUMP table and enable the KDUMP feature remotely.