sonic-host-services changes for gNOI Warm Reboot #191
Conversation
rkavitha-hcl
force-pushed
the
gnoi_wr_hs_new
branch
from
e42ae0a to
76f70db
Compare
host_modules/gnoi_reboot.py
Outdated
|
|
||
| # Timeout for SONiC Host Service to be killed during reboot | ||
| REBOOT_TIMEOUT = 260 | ||
|
|
||
| EXECUTE_COLD_REBOOT_COMMAND = "sudo reboot" | ||
| EXECUTE_NSF_REBOOT_COMMAND = "/etc/init.d/gpins-nsf-boot nsf-reboot" | ||
| EXECUTE_WARM_REBOOT_COMMAND = "/usr/local/bin/warm-reboot -v" |
There was a problem hiding this comment.
@hdwhdw @qiluo-msft Can you pls confirm this is the right command to invoke warm reboot in SONiC ?
There was a problem hiding this comment.
|
@github76543 Joh, can you PTAL and signoff. |
rkavitha-hcl
force-pushed
the
gnoi_wr_hs_new
branch
2 times, most recently
from
a230e6e to
f71371e
Compare
host_modules/gnoi_reboot.py
Outdated
|
|
||
| # Timeout for SONiC Host Service to be killed during reboot | ||
| REBOOT_TIMEOUT = 260 | ||
|
|
||
| EXECUTE_COLD_REBOOT_COMMAND = "sudo reboot" | ||
| EXECUTE_NSF_REBOOT_COMMAND = "/etc/init.d/gpins-nsf-boot nsf-reboot" | ||
| EXECUTE_WARM_REBOOT_COMMAND = "/usr/local/bin/warm-reboot -v" |
There was a problem hiding this comment.
Thanks @hdwhdw for the reference. The reboot dbus service also needs a request/response framework which is what this PR does and IIUC @vvolam went with the other one as a stop gap solution. Adding @github76543 (John) for additional inputs. |
|
@kishanps thanks for clarifying. If so consider renaming the service to something more general than gnoi_reboot. Maybe 'async_system'? Having one module for each gnoi service can clutter the dbus codebase. Also does it make sense to add your api to systemd service and call it async reboot, alongside @vvolam API? |
rkavitha-hcl
force-pushed
the
gnoi_wr_hs_new
branch
from
f71371e to
12e3f91
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@hdwhdw @github76543 @rkavitha-hcl @jaanah-hcl I discussed with John, Dawei Huang & @vvolam and we all agree that reboot will be a separate dbus service and hence rename gnoi_reboot to just reboot. And remove the commit id ff73070 alongwith this PR to avoid the duplication. |
rkavitha-hcl
force-pushed
the
gnoi_wr_hs_new
branch
from
12e3f91 to
f568f97
Compare
|
/azp run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
No description provided.