Review comments; No logical code change

sonic-net · Feb 16, 2022 · 5bbcc42 · 5bbcc42
1 parent b399799
commit 5bbcc42
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/tests/configlet/test_add_rack.py b/tests/configlet/test_add_rack.py
@@ -19,7 +19,7 @@ def configure_dut(duthosts, rand_one_dut_hostname):
         if not restore_orig_minigraph(duthosts[rand_one_dut_hostname]):
             backup_minigraph(duthosts[rand_one_dut_hostname])
         log_info("configure_dut fixture DONE for {}".format(rand_one_dut_hostname))
-        yield 0
+        yield
     finally:
         log_info("configure_dut fixture on cleanup for {}".format(rand_one_dut_hostname))
         restore_orig_minigraph(duthosts[rand_one_dut_hostname])

diff --git a/tests/configlet/util/base_test.py b/tests/configlet/util/base_test.py
@@ -227,9 +227,8 @@ def do_test_add_rack(duthost, is_storage_backend = False, skip_load=False,
 
     init(duthost)
 
-    fpath = "/usr/local/lib/python3.9/dist-packages/generic_config_updater/services_validator.py"
-    ret = duthost.stat(path=fpath)
-    if not ret["stat"]["exists"]:
+    ret = duthost.shell("python3 -c 'import generic_config_updater'")
+    if ret["rc"]:
         log_info("Skipping generic patch test as file does not exist: {}".format(fpath))
         skip_generic_add = True
         skip_generic_rm = True