[action] [PR:10612] Enhance restore_bgp_suppress_fib to check status first #10624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the motivation for this PR? In current test, it will set the bgp suppress to disabled no matter what's the value in the config_db. If it is enabled before the test, it should honor it, and don't change it after the test. In this PR, will add a check logic to restore only it is needed. How did you do it? To read back the config db before test, then do the restore when it is needed. How did you verify/test it? enable the fib suppress. run bgp suppress fib test. check the config, if it is same as before.
7 tasks
|
Original PR: #10612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
ADO: 25564723
Type of change
Back port request
Approach
What is the motivation for this PR?
In current test, it will set the bgp suppress to disabled no matter what's the value in the config_db. If it is enabled before the test, it should honor it, and don't change it after the test.
In this PR, will add a check logic to restore only it is needed.
How did you do it?
To read back the config db before test, then do the restore when it is needed.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation