[action] [PR:8097] Add a test case to verify that BGP packets use queue7 #10641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All control packets including BGP are expected to use Q7, separate from data packet queues * Check for q7 counters is not being done until regression due to sonic-net/sonic-swss#2143 is fixed Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
mssonicbld
requested review from
StormLiangMS,
wangxin and
yxieca
as code owners
6 tasks
|
Original PR: #8097 |
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #7695
Type of change
Back port request
Approach
What is the motivation for this PR?
It was observed that control packets use queue 0 in TD2 platforms which can lead to these packets being lost when link utilization becomes close to 100%. This can lead to critical issues in field like BGP keepalive failures. This management test is a way to make sure that this doesn't happen again in production.
How did you do it?
By bringing up BGP sessions with neighbors and making sure that BGP control traffic uses queue 7 by default using "show queue counters".
How did you verify/test it?
By running the test and making sure that it works as expected, reporting success or failure depending on which queues are used by control packets.
Any platform specific information?
This is applicable to all platforms.
Supported testbed topology if it's a new test case?
Documentation