Modified ssdhealth test to account for currently supported disk types #14071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assrinivasan
requested review from
cyw233,
nhe-NV,
saiarcot895,
prgeor,
vdahiya12,
mihirpat1 and
vvolam
and removed request for
prgeor
|
Test failure appears to not be connected with this PR. |
prgeor
reviewed
Oct 28, 2024
prgeor
approved these changes
Oct 30, 2024
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
…sonic-net#14071) * Modified ssdhealth test to account for currently supported disk types * Print unsupported storage disk type before skipping test
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
…sonic-net#14071) * Modified ssdhealth test to account for currently supported disk types * Print unsupported storage disk type before skipping test
|
@prgeor , may I ask is there any plan to merge the fixe to 202405 branch? |
|
After sonic-net/sonic-utilities#3399 got cherry-picke and advanced into 202405 branch, platform_tests/cli/test_show_platform.py reports failure due to mismatch |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 11, 2024
…sonic-net#14071) * Modified ssdhealth test to account for currently supported disk types * Print unsupported storage disk type before skipping test
|
Cherry-pick PR to 202405: #16011 |
Merged
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 11, 2024
…#14071) * Modified ssdhealth test to account for currently supported disk types * Print unsupported storage disk type before skipping test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This is a sonic-mgmt test for sonic-buildimage issue 9407, which has a fix PR raised here: sonic-net/sonic-utilities#3399 -- the change in this PR tests that fix.
Type of change
Back port request
Approach
What is the motivation for this PR?
show platform ssdhealthfails on certain platforms such as Arista 7050qx because the sonic utility that the command calls relies onsmartctloutput, which fails on storage device of type EUSB. This PR skips the test on unsupported disk types.How did you do it?
Added a new field
Disk Typeto thessdutilsonic-utility that theshow platform ssdhealthcalls. The test checks for a supported disk type and skips if not found.How did you verify/test it?
Tested on 4 HWSKUs each with storage disk type EUSB (skip), EMMC (skip), SATA (pass) and NVME (pass). Logs are attached here: test_show_platform_ssdhealth.txt
Any platform specific information?
Skipped on platforms with storage device type EUSB and EMMC.
Supported testbed topology if it's a new test case?
Documentation