Fix get_monit_services_status logic #16013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
MSFT ADO: 30481994 |
arlakshm
approved these changes
Dec 11, 2024
arlakshm
approved these changes
Dec 11, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 11, 2024
What is the motivation for this PR? The current logic simply checks for the keyword "status" in service_info without considering the context. If the keyword appears in 'last output' or another unintended section of the data, the logic misinterprets it. How did you do it? Ensuring "status" detection is specific to the intended line. Using a stricter parsing approach to avoid unintended matches. How did you verify/test it? Ran the test_pretest.py on kvm-t0 testbed. Captured the get_monit_services_status() output
|
Cherry-pick PR to 202405: #16024 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 12, 2024
What is the motivation for this PR? The current logic simply checks for the keyword "status" in service_info without considering the context. If the keyword appears in 'last output' or another unintended section of the data, the logic misinterprets it. How did you do it? Ensuring "status" detection is specific to the intended line. Using a stricter parsing approach to avoid unintended matches. How did you verify/test it? Ran the test_pretest.py on kvm-t0 testbed. Captured the get_monit_services_status() output
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
This was referenced Dec 12, 2024
rlhui
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Dec 13, 2024
This PR fixes sonic-net/sonic-buildimage#18773 and sonic-net/sonic-buildimage#20648 Note: resubmitting the Old PR #3544 (with minor cosmetic changes). The original PR was reverted due to PR check failure. The failure has been root caused and fixed via sonic-net/sonic-mgmt#16013 How I did it Parallely execute route_check on each Asic. Parallelly fetch ipv4 routes and ipv6 routes.
abdosi
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Dec 15, 2024
This PR fixes sonic-net/sonic-buildimage#18773 and sonic-net/sonic-buildimage#20648 Note: resubmitting the PR. The original PR was reverted due to PR check failure. The failure has been root caused and fixed via sonic-net/sonic-mgmt#16013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix the logic to parse "sudo monit status" output in get_monit_services_status()
Type of change
Back port request
Approach
What is the motivation for this PR?
The current logic simply checks for the keyword "status" in service_info without considering the context. If the keyword appears in 'last output' or another unintended section of the data, the logic misinterprets it.
How did you do it?
Ensuring "status" detection is specific to the intended line. Using a stricter parsing approach to avoid unintended matches.
How did you verify/test it?
Ran the test_pretest.py on kvm-t0 testbed. Captured the get_monit_services_status() output
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
Documentation