-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deploying topo issue caused by request 2.32.0 lib #16452
Open
JibinBao
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
JibinBao:fix_docker_python3_issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
JibinBao
changed the title
FIx deploy topo issued caused by https://github.com/ansible-collections/community.docker/issues/860
FIx deploying topo issue caused by https://github.com/ansible-collections/community.docker/issues/860
Jan 10, 2025
JibinBao
changed the title
FIx deploying topo issue caused by https://github.com/ansible-collections/community.docker/issues/860
Fix deploying topo issue caused by https://github.com/ansible-collections/community.docker/issues/860
Jan 10, 2025
JibinBao
changed the title
Fix deploying topo issue caused by https://github.com/ansible-collections/community.docker/issues/860
Fix deploying topo issue caused by request 2.32.0 lib
Jan 10, 2025
nhe-NV
approved these changes
Jan 10, 2025
/azpw run Azure.sonic-mgmt |
/AzurePipelines run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run Azure.sonic-mgmt |
/AzurePipelines run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When Python version of the server is python3, it will update the docker lib. At the same time updating docker lib will also update the dependeny lib requests to latest version. unfortunatly the latest version of 2.32.0 has issue:ansible-collections/community.docker#860. So specify the request version to 2.31.0.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix deploy issue caused by ansible-collections/community.docker#860
How did you do it?
specify the request version to 2.31.0.
How did you verify/test it?
depoy topo on server with python3
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Documentation