-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to wrap verify_only_loopback_routes with assert and wait_until #16523
Merged
yejianquan
merged 4 commits into
sonic-net:master
from
Javier-Tan:reliable_tsa_wait_until_loopback
Jan 29, 2025
Merged
Add function to wrap verify_only_loopback_routes with assert and wait_until #16523
yejianquan
merged 4 commits into
sonic-net:master
from
Javier-Tan:reliable_tsa_wait_until_loopback
Jan 29, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
previously approved these changes
Jan 17, 2025
tjchadaga
approved these changes
Jan 17, 2025
One part of #16577 |
Javier-Tan
added
Request for msft-202405 Branch
and removed
Request for 202405 branch
labels
Jan 18, 2025
Javier-Tan
changed the title
Add wait_until for verify_only_loopback_routes in test_reliable_tsa.py
Add function to wrap verify_only_loopback_routes with assert and wait_until
Jan 21, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sanjair-git
approved these changes
Jan 21, 2025
arlakshm
previously approved these changes
Jan 28, 2025
Hi @Javier-Tan, can you resolve the conflicts |
… update * Add wait_until for verify_only_loopback_routes Signed-off-by: Javier Tan javiertan@microsoft.com
* Remove trailing whitespace Signed-off-by: Javier Tan javiertan@microsoft.com
* Add function which wraps verify_only_loopback_routes_... with assert and wait_until Signed-off-by: Javier Tan javiertan@microsoft.com
Javier-Tan
force-pushed
the
reliable_tsa_wait_until_loopback
branch
from
January 29, 2025 00:22
e1b7316
to
d85dcca
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
* Remove trailing whitespace Signed-off-by: Javier Tan javiertan@microsoft.com
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@arlakshm @yejianquan conflicts has been resolved, could you help re-review/merge? Thanks so much! |
yejianquan
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Javier-Tan
added
Included in msft-202405 Branch
and removed
Cherry Pick Conflict_msft-202405
labels
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Partially tackles #16577
Type of change
Back port request
Approach
What is the motivation for this PR?
Tests are flaky, sometimes failing on
verify_only_loopback_routes_are_announced_to_neighs
:Failed to verify routes on nbr in TSA
How did you do it?
Add a function wrapping
verify_only_loopback_routes_are_announced_to_neighs
with wait_until and assert to allow time for neighbor to update routesHow did you verify/test it?
These logs were seen in passed tests, showing that wait_until helps avoid false negatives
All affected test suites were run
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A