[action] [PR:16623] Updating ecn helper.py under snappi_tests to capture udp packets. #16719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nic-net#16623) To take into account UDP packets. Previously, it was considering IP packets. Now as the UDP header has been added to the data packets, we have to capture the UDP packets. Description of PR Summary: Fixes # (issue) Fixed the helper file. Approach What is the motivation for this PR? Test is failing as it is expecting IP packets but sending UDP packets. How did you do it? Modified the helper file to have the protocol number as 17, so that it tries to capture udp packets. How did you verify/test it? Ran on T0/T1 device Any platform specific information? Supported testbed topology if it's a new test case? Supported snappi test bed co-authorized by: jianquanye@microsoft.com
|
/azp run |
10 tasks
|
Original PR: #16623 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To take into account UDP packets. Previously, it was considering IP packets. Now as the UDP header has been added to the data packets, we have to capture the UDP packets.
Description of PR
Summary:
Fixes # (issue)
Fixed the helper file.
Type of change
Back port request
Approach
What is the motivation for this PR?
Test is failing as it is expecting IP packets but sending UDP packets.
How did you do it?
Modified the helper file to have the protocol number as 17, so that it tries to capture udp packets.
How did you verify/test it?
Ran on T0/T1 device
Any platform specific information?
Supported testbed topology if it's a new test case?
Supported snappi test bed
Documentation