Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform] Update SFP keys to reflect new naming convention #1919

Merged
merged 1 commit into from
Jul 17, 2020
Merged

[platform] Update SFP keys to reflect new naming convention #1919

merged 1 commit into from
Jul 17, 2020

Conversation

jleveque
Copy link
Contributor

Update transceiver info keys to reflect change at sonic-net/sonic-platform-common#97 as follows:

hardwarerev -> hardware_rev
serialnum -> serial
manufacturename -> manufacturer
modelname -> model

@jleveque jleveque requested a review from yxieca July 17, 2020 04:45
@jleveque jleveque self-assigned this Jul 17, 2020
@yxieca
Copy link
Collaborator

yxieca commented Jul 17, 2020

Do we need this change in 201911 and 202006?

@jleveque
Copy link
Contributor Author

Yes, but we don't have 201911 or 202006 branches in this repo yet.

@jleveque jleveque merged commit ea264d7 into sonic-net:master Jul 17, 2020
@jleveque jleveque deleted the update_sfp_keys branch July 17, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca approved these changes

Assignees

@jleveque jleveque

Labels
Enhancement Platform Pytest 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @yxieca