[qos] Headroom pool watermark test #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Dec 3, 2020
neethajohn
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 9, 2020
What I did Added 'SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES' in the interested counters to be queried Updated the the buffer lua script to update the headroom pool watermark counters Updated watermark orch to act on headroom pool clear request Why I did it To expose the headroom pool watermark counters in SONiC How I verified it On platforms with headroom pool support, verified that headroom pool watermark counters are getting updated as expected On platforms without headroom pool support, headroom pool watermark counters show as N/A New sonic mgmt test added and it passed. sonic-net/sonic-mgmt#2614 Signed-off-by: Neetha John <nejo@microsoft.com>
arlakshm
pushed a commit
to arlakshm/sonic-swss
that referenced
this pull request
Dec 15, 2020
What I did Added 'SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES' in the interested counters to be queried Updated the the buffer lua script to update the headroom pool watermark counters Updated watermark orch to act on headroom pool clear request Why I did it To expose the headroom pool watermark counters in SONiC How I verified it On platforms with headroom pool support, verified that headroom pool watermark counters are getting updated as expected On platforms without headroom pool support, headroom pool watermark counters show as N/A New sonic mgmt test added and it passed. sonic-net/sonic-mgmt#2614 Signed-off-by: Neetha John <nejo@microsoft.com> Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
neethajohn
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 23, 2020
Signed-off-by: Neetha John <nejo@microsoft.com> Includes all the changes in #1453 along with fix for error msgs seen in syslog - Got invalid response type from redis 5 The error msg was due to incorrect return type in lua script. What I did Added 'SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES' in the interested counters to be queried Updated the the buffer lua script to update the headroom pool watermark counters Updated watermark orch to act on headroom pool clear request Why I did it To expose the headroom pool watermark counters in SONiC How I verified it On platforms with headroom pool support, verified that headroom pool watermark counters are getting updated as expected admin@sonic:~$ show headroom-pool persistent-watermark Headroom pool maximum occupancy: Pool Bytes --------------------- ------- ingress_lossless_pool 863616 On platforms without headroom pool support, headroom pool watermark counters show as N/A admin@sonic:~$ show headroom-pool persistent-watermark Headroom pool maximum occupancy: Pool Bytes --------------------- ------- ingress_lossless_pool N/A New sonic mgmt test added and it passed. sonic-net/sonic-mgmt#2614 Verified the error msg seen in syslog by enabling buffer pool watermark on vs docker. With the fix, build a new vs docker and verified that the msgs are no longer seen when buffer pool watermark is enabled.
Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
Signed-off-by: Neetha John <nejo@microsoft.com>
neethajohn
force-pushed
the
hdrm_pool_wm
branch
from
a3552f7 to
121e170
Compare
|
retest vs please |
|
retest this please |
|
retest vsimage please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Depends on sonic-net/sonic-swss#1453
Type of change
Approach
What is the motivation for this PR?
Add tests for the headroom pool watermark feature
How did you verify/test it?
Ran the test on Th2 on an image with the headroom pool wm feature changes and it passed