Add space before extra arguments for renumber_topo and restart_ptf #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the testbed-cli.sh tool, extra arguments can be passed to the playbook for renumber_topo and restart_ptf. However, there is no whitespace before the extra arguments `$@`. Then the extra arguments will be part of value of ansible variable `ptf_ipv6`. This command works: ./testbed-cli.sh restart-ptf <testbed_name> password.txt This command will fail: ./testbed-cli.sh restart-ptf <testbed_name> password.txt -vv The last "-vv" will be appended to value of ansible variable `ptf_ipv6`. The fix is just to add a white space before `$@`. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
lolyu
approved these changes
May 31, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…onic-net#3558) In the testbed-cli.sh tool, extra arguments can be passed to the playbook for renumber_topo and restart_ptf. However, there is no whitespace before the extra arguments `$@`. Then the extra arguments will be part of value of ansible variable `ptf_ipv6`. This command works: ./testbed-cli.sh restart-ptf <testbed_name> password.txt This command will fail: ./testbed-cli.sh restart-ptf <testbed_name> password.txt -vv The last "-vv" will be appended to value of ansible variable `ptf_ipv6`. The fix is just to add a white space before `$@`. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
In the testbed-cli.sh tool, extra arguments can be passed to the playbook for
renumber_topo and restart_ptf. However, there is no whitespace before the
extra arguments
$@. Then the extra arguments will be part of value of ansiblevariable
ptf_ipv6. This command works:./testbed-cli.sh restart-ptf <testbed_name> password.txt
This command will fail:
./testbed-cli.sh restart-ptf <testbed_name> password.txt -vv
The last "-vv" will be appended to value of ansible variable
ptf_ipv6.How did you do it?
The fix is just to add a white space before
$@.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation