[M0 topologies] reduce the podset count of M0 topology to 30 #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
neethajohn
reviewed
Jun 25, 2021
| @@ -94,7 +94,7 @@ configuration_properties: | |||
| dut_asn: 65100 | |||
There was a problem hiding this comment.
Is this topology only used by M0?
There was a problem hiding this comment.
I only see M0 using it in our repo.
There was a problem hiding this comment.
In future, we need to make this topology specific to mgmtToR so that we don't use this for T0
neethajohn
reviewed
Jun 25, 2021
neethajohn
approved these changes
Jun 25, 2021
sumukhatv
approved these changes
Jun 25, 2021
|
@rawal01 for visibility |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…et#3706) What is the motivation for this PR? M0 devices deployed with topo-52 or topo-mgmttor crashes at start up due to ASIC doesn't have enough memory to hold regular amount of routes. How did you do it? Reduce number of routes announcing to the DUT. How did you verify/test it? remove-topo/add-topo and verify the route count drops and DUT no longer crash. Signed-off-by: Ying Xie ying.xie@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change
Approach
What is the motivation for this PR?
M0 devices deployed with topo-52 or topo-mgmttor crashes at start up due to ASIC doesn't have enough memory to hold regular amount of routes.
How did you do it?
Reduce number of routes announcing to the DUT.
How did you verify/test it?
remove-topo/add-topo and verify the route count drops and DUT no longer crash.
Signed-off-by: Ying Xie ying.xie@microsoft.com