-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the show ip/ipv6 bgp test ro user commands #4949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
previously approved these changes
Jan 14, 2022
The test_ro_user does not work as expected, the test should be failed.
We cannot use the return value to check whether ro permission is correct or not. |
wangxin
approved these changes
Jan 17, 2022
qiluo-msft
approved these changes
Jan 17, 2022
Waiting for all the following PRs complete. |
This is an old PR which has already been included in 202012 when it was branched off. |
wangxin
pushed a commit
that referenced
this pull request
Mar 16, 2022
Add UTs to cover the 'show ip bgp' ro commands. Fix some of the commands that prompt rw required message, but not detected issue. Add stricter testing checks, for any ro/rw commands, if any error log which contains the "RW permission" required message, the UT will be failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add UTs to cover the 'show ip bgp' ro commands.
Fix some of the commands that prompt rw required message, but not detected issue.
Add stricter testing checks, for any ro/rw commands, if any error log which contains the "RW permission" required message, the UT will be failed.
The checks will be succeeded after the PR sonic-net/sonic-utilities#2011 merged.
Type of change
Back port request
Approach
What is the motivation for this PR?
Add test cases for PR sonic-net/sonic-utilities#2011
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation