Remove test reset check for GCU test #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jan 24, 2022
| @@ -188,7 +219,7 @@ def dhcp_severs_by_vlanid(duthost, vlanid): | |||
| root 73 1 0 06:39 pts/0 00:00:00 /usr/sbin/dhcrelay -d -m discard -a %h:%p %P --name-alias-map-file /tmp/port-name-alias-map.txt -id Vlan1000 -iu Vlan100 -iu PortChannel0001 -iu PortChannel0002 -iu PortChannel0003 -iu PortChannel0004 192.0.0.1 192.0.0.2 192.0.0.3 192.0.0.4 | |||
| """ | |||
| cmds = "docker exec dhcp_relay supervisorctl status | grep ^dhcp-relay \ | |||
qiluo-msft
reviewed
Jan 24, 2022
| syslog_config_cleanup(duthost, cfg_facts) | ||
|
|
||
| if init_syslog_config == CONFIG_ADD_DEFAULT: | ||
| if init_syslog_config == CONFIG_CLEANUP: |
There was a problem hiding this comment.
Updated PR motivation. Please have a look. Thanks
qiluo-msft
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Remove test reset check for GCU test cause GCU feature will take care of it
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Dhcp_relay test: Remove reset check and rollback instead of reload. Use MACRO for each setup. Add try catch for each test to ensure checkpoint is removed after test.
Syslog test: Rename function. Setup code restructure. No logical change.
How did you do it?
Remove code related
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_dhcp_relay.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation