Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling testQosSaiBufferPoolWatermark Testcase for cisco-8000 platform #5512

Merged
merged 2 commits into from
May 12, 2022
Merged

Enabling testQosSaiBufferPoolWatermark Testcase for cisco-8000 platform #5512

merged 2 commits into from
May 12, 2022

Conversation

jsanghra
Copy link
Contributor

Description of PR

Enables testQosSaiBufferPoolWatermark on Cisco-8000.

Additional utilities:

  • Packet leakout variance is accounted for by a new function in sai_qos_tests.py.
  • Adds sai thrift function to obtain queue occupancy for leakout accounting.

Test case modifications for Cisco-8000:

  • Ignore “--disable_test”.
  • Allow the watermark to start at a non-zero value.
  • Add packet_size support.
  • Increase margins according to cell occupancy from packet size.
  • Slightly larger lower bound.
  • Initial number of packets sent decreased to 1 without a margin.

The above changes are backwards compatible with other vendors.

What is the motivation for this PR?

Provide Cisco-8000 support for testQosSaiBufferPoolWatermark.

How did you verify/test it?

Verified the Changes on Cisco platform and Testcase Passes

@jsanghra jsanghra requested a review from a team as a code owner April 14, 2022 18:41
@ghost
Copy link

ghost commented Apr 14, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

kevinskwang
kevinskwang reviewed Apr 20, 2022
View reviewed changes
tests/qos/test_qos_sai.py Show resolved Hide resolved
tests/qos/test_qos_sai.py Show resolved Hide resolved
tests/saitests/sai_qos_tests.py Show resolved Hide resolved
tests/saitests/sai_qos_tests.py Show resolved Hide resolved
This was referenced Apr 20, 2022
Merged
Merged
Merged
Merged
@kevinskwang kevinskwang merged commit c453cf4 into sonic-net:master May 12, 2022
wangxin pushed a commit that referenced this pull request May 13, 2022
@jsanghra @wangxin
Enabling testQosSaiBufferPoolWatermark Testcase for cisco-8000 platfo…
2d4c1e6 
…rm (#5512)

* Changes for Bufferpool Watermark Testcase for cisco-8000 platform

* removing sleep from fill_leakout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbpittman rbpittman rbpittman left review comments

@kevinskwang kevinskwang kevinskwang approved these changes

Assignees
No one assigned
Labels
Included in 202012 branch Request for 202012 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsanghra @rbpittman @kevinskwang @wangxin