Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests/override_config_table] load_minigraph with Golden Config test #5625

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented May 9, 2022

Description of PR

Summary: E2E test for load minigraph with Golden Config file
Wait sonic-utilities feature sonic-net/sonic-utilities#2140 merge in sonic-buildimage
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

This PR is to verify load minigraph with Golden Config and see if Golden Config overrides minigraph.
This test contains below phases:
I. Empty Golden Config
II. Partial Golden Config
III. New Feature in Golden Config
IV. Full Golden Config

How did you do it?

Write E2E test to verify

How did you verify/test it?

Run E2E test on kvm

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wen587
Copy link
Contributor Author

wen587 commented May 17, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft
qiluo-msft previously approved these changes May 17, 2022
@wen587
Copy link
Contributor Author

wen587 commented May 31, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

else:
duthost.file(path=GOLDEN_CONFIG, state='absent')

# Restore config before test
Copy link
Contributor

@qiluo-msft qiluo-msft Jun 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before

You mean "after this test"? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mean restore to the config when the test is not started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants