-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests/override_config_table] load_minigraph with Golden Config test #5625
Merged
+156
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
May 10, 2022
qiluo-msft
reviewed
May 10, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
May 17, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jun 6, 2022
else: | ||
duthost.file(path=GOLDEN_CONFIG, state='absent') | ||
|
||
# Restore config before test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mean restore to the config when the test is not started.
qiluo-msft
approved these changes
Jun 7, 2022
neethajohn
pushed a commit
that referenced
this pull request
Jun 8, 2022
…ig test (#5625)" (#5786) This reverts commit e9e1190. Reverts #5625 Reason: The change is breaking PR testing for sonic-buildimage 202012 branch https://dev.azure.com/mssonic/build/_build/results?buildId=107136&view=logs&j=5586bfe1-aa8d-5715-639b-d385a1c8f47c&t=acd2fe75-3c5c-5360-f588-611777c47a8e https://dev.azure.com/mssonic/build/_build/results?buildId=107136&view=logs&s=ee3800fd-6e81-525f-e564-94108585217d&j=5586bfe1-aa8d-5715-639b-d385a1c8f47c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: E2E test for load minigraph with Golden Config file
Wait sonic-utilities feature sonic-net/sonic-utilities#2140 merge in sonic-buildimage
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to verify load minigraph with Golden Config and see if Golden Config overrides minigraph.
This test contains below phases:
I. Empty Golden Config
II. Partial Golden Config
III. New Feature in Golden Config
IV. Full Golden Config
How did you do it?
Write E2E test to verify
How did you verify/test it?
Run E2E test on kvm
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation