Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests/generic_config_updater] improve GCU portchannel test #5802

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Jun 13, 2022

Description of PR

Summary: Improve GCU po test when the initial po interface ip are different
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

The test will fail on some t0-topo when the initial po interfaces are not the same as the assumed ones.
For example, t0-116's PO101's ip is 10.0.0.32, which differs from t0's10.0.0.56.
GCU po test failed in t0-116 as the init po101's ip was assumed to be 10.0.0.56

How did you do it?

Change to read po ip from the configuration.

How did you verify/test it?

Run kvm test.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wen587 wen587 marked this pull request as ready for review June 13, 2022 08:10
@wen587 wen587 requested a review from a team as a code owner June 13, 2022 08:10
@wen587 wen587 requested a review from qiluo-msft June 13, 2022 08:11
@wen587 wen587 merged commit 0cba182 into sonic-net:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants