-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip test_cacl_application to unblock sub module update of sonic-host-services #6585
Skip test_cacl_application to unblock sub module update of sonic-host-services #6585
Conversation
by default in caclmgrd in sonic-host-services sub-module is blocking sonic-host-services sub module update. Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
…-services (sonic-net#6585) What is the motivation for this PR? Recent change in caclmgrd caused the expected ACL list to change. test_cacl_application fails because the expected ACLs are not present on DUT. This is occurring with latest sonic-host-services changes, and is blocking sub module update. Test case has to be updated, but updated test case will fail without the latest changes from sonic-host-services. This PR is to ensure that sub module is updated so that the test case can pass. issue: sonic-net/sonic-buildimage#12464 submodule update PR that is blocked: sonic-net/sonic-buildimage#12195 How did you do it? skip test_cacl_application.
Signed-off-by: Suvarna Meenakshi sumeenak@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Recent change in caclmgrd caused the expected ACL list to change.
test_cacl_application fails because the expected ACLs are not present on DUT.
This is occurring with latest sonic-host-services changes, and is blocking sub module update.
Test case has to be updated, but updated test case will fail without the latest changes from sonic-host-services. This PR is to ensure that sub module is updated so that the test case can pass.
issue: sonic-net/sonic-buildimage#12464
submodule update PR that is blocked: sonic-net/sonic-buildimage#12195
How did you do it?
skip test_cacl_application.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation