Skip to content

Commit

Permalink
[Thinkit] Use absl::Cleanup to make sure thread is joined even if tes…
Browse files Browse the repository at this point in the history
…t failed.[tests/flow] Only call `ClearTableEntries` when session is not null. Prolong traffic time for `VerifySamplingSizeWorks`.Use `BiglabStubCache` to generate a Testbed stub for `sflow_inband_test`. Enable punt test case.`ExtractTosFromTcpdumpResult` should return an error when ToS values are not the same. Verify ToS values are correctly set using tcpdump. (#885)



Co-authored-by: kishanps <kishanps@google.com>
  • Loading branch information
VSuryaprasad-HCL and kishanps authored Dec 30, 2024
1 parent 90869e4 commit 8d48846
Show file tree
Hide file tree
Showing 6 changed files with 367 additions and 150 deletions.
1 change: 1 addition & 0 deletions tests/qos/packet_in_receiver.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class PacketInReceiver final {

// It's ok to call this function multiple times.
void Destroy() {
session_.Finish();
if (receiver_.joinable()) {
stop_receiving_.Notify();
receiver_.join();
Expand Down
2 changes: 2 additions & 0 deletions tests/sflow/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ cc_library(
"//tests/lib:p4rt_fixed_table_programming_helper",
"//tests/lib:switch_test_setup_helpers",
"//tests/qos:gnmi_parsers",
"//tests/qos:packet_in_receiver",
"//tests/qos:qos_test_util",
"//thinkit:generic_testbed",
"//thinkit:generic_testbed_fixture",
Expand All @@ -57,6 +58,7 @@ cc_library(
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/synchronization",
"@com_google_absl//absl/time",
"@com_google_absl//absl/types:span",
"@com_google_googletest//:gtest",
Expand Down
Loading

0 comments on commit 8d48846

Please sign in to comment.