Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Thinkit] Test sFlow interface counter value during standalone test. Use pins-sampling-sflow namespace for actual-ingress-sampling-rate. do not fail test when /etc/hsflowd.auto is not present. Add a restart test. #898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Thinkit] Test sFlow interface counter value during standalone test. Use pins-sampling-sflow namespace for actual-ingress-sampling-rate. do not fail test when /etc/hsflowd.auto is not present. Add a restart test. #898

wants to merge 1 commit into from
+347 −146

Conversation

VSuryaprasad-HCL
Copy link
Contributor

Key_word Check:

~/pins_upstream/sonic-buildimage/src/sonic-p4rt/sonic-pins/tests/sflow$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build result:

/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 638 targets (0 packages loaded, 0 targets configured).
INFO: Found 638 targets...
INFO: Elapsed time: 0.533s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Test result:

/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 638 targets (0 packages loaded, 0 targets configured).
INFO: Found 426 targets and 212 test targets...
INFO: Elapsed time: 161.150s, Critical Path: 115.30s
INFO: 266 processes: 321 linux-sandbox, 18 local.
INFO: Build completed successfully, 266 total actions
//dvaas:port_id_map_test                                                 PASSED in 1.5s
//dvaas:test_run_validation_golden_test                                  PASSED in 0.1s
//dvaas:test_run_validation_test                                         PASSED in 1.0s
//dvaas:test_run_validation_test_runner                                  PASSED in 0.1s
//dvaas:test_vector_stats_diff_test                                      PASSED in 0.1s
//dvaas:test_vector_stats_test                                           PASSED in 0.1s
//thinkit:mock_control_device_test                                       PASSED in 1.0s
//thinkit:mock_generic_testbed_test                                      PASSED in 1.4s
//thinkit:mock_mirror_testbed_test                                       PASSED in 1.2s
//thinkit:mock_ssh_client_test                                           PASSED in 0.2s
//thinkit:mock_switch_test                                               PASSED in 1.6s
//thinkit:mock_test_environment_test                                     PASSED in 0.1s
//thinkit:switch_test                                                    PASSED in 1.3s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test     PASSED in 1.6s
  Stats over 5 runs: max = 1.6s, min = 1.1s, avg = 1.3s, dev = 0.2s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test     PASSED in 43.6s
  Stats over 50 runs: max = 43.6s, min = 0.9s, avg = 3.3s, dev = 8.2s

Executed 212 out of 212 tests: 212 tests pass.
INFO: Build completed successfully, 266 total actions

@mssonicbld
Copy link

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

jaanah-hcl
jaanah-hcl reviewed Dec 26, 2024
View reviewed changes
tests/sflow/sflow_util.cc Outdated
@@ -405,7 +408,7 @@ GetSflowActualSamplingRateForInterfaces(
const absl::flat_hash_set<std::string>& interfaces) {
absl::flat_hash_map<std::string, int> interface_to_sample_rate;
const std::string parse_ops_str =
"openconfig-sampling-sflow:actual-ingress-sampling-rate";
"google-pins-sampling-sflow:actual-ingress-sampling-rate";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change google-pins to pins

jaanah-hcl
jaanah-hcl reviewed Dec 26, 2024
View reviewed changes
tests/sflow/sflow_util_test.cc Outdated
@@ -681,7 +681,7 @@ TEST(SflowUtilTest, GetActualSampleRateSuccessForAllInterfaces) {
prefix { origin: "openconfig" }
update {
val {
json_ietf_val: "{\"openconfig-sampling-sflow:actual-ingress-sampling-rate\":256}"
json_ietf_val: "{\"google-pins-sampling-sflow:actual-ingress-sampling-rate\":256}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change google-pins to pins

jaanah-hcl
jaanah-hcl reviewed Dec 26, 2024
View reviewed changes
tests/sflow/sflow_util_test.cc Outdated
@@ -704,7 +704,7 @@ TEST(SflowUtilTest, GetActualSampleRateInvalidSampleRateFail) {
prefix { origin: "openconfig" }
update {
val {
json_ietf_val: "{\"openconfig-sampling-sflow:actual-ingress-sampling-rate\":\"abc\"}"
json_ietf_val: "{\"google-pins-sampling-sflow:actual-ingress-sampling-rate\":\"abc\"}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change google-pins to pins

jaanah-hcl
jaanah-hcl suggested changes Dec 26, 2024
View reviewed changes
Copy link

@jaanah-hcl jaanah-hcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change google-pins to pins in all the commented places

@mssonicbld
Copy link

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@VSuryaprasad-HCL VSuryaprasad-HCL changed the title [Thinkit] Test sFlow interface counter value during standalone test. Use google-pins-sampling-sflow namespace for actual-ingress-sampling-rate. do not fail test when /etc/hsflowd.auto is not present. Add a restart test. [Thinkit] Test sFlow interface counter value during standalone test. Use pins-sampling-sflow namespace for actual-ingress-sampling-rate. do not fail test when /etc/hsflowd.auto is not present. Add a restart test. Dec 27, 2024
@mssonicbld
Copy link

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@mssonicbld
Copy link

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@kishanps @VSuryaprasad-HCL
[Thinkit] Test sFlow interface counter value during standalone test. …
2339973 
…Use `google-pins-sampling-sflow` namespace for `actual-ingress-sampling-rate`. do not fail test when `/etc/hsflowd.auto` is not present. Add a restart test.
@mssonicbld
Copy link

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaanah-hcl jaanah-hcl jaanah-hcl requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VSuryaprasad-HCL @mssonicbld @jaanah-hcl @kishanps