Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fan_drawer_base.py] Fix FanDrawer get_status_led interface #175

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

vboykox
Copy link
Member

@vboykox vboykox commented Mar 8, 2021

Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com

Description

Fix api to conform the description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
@vboykox
Copy link
Member Author

vboykox commented Mar 9, 2021

@Junchao-Mellanox
@tim-rj sonic_rd@ruijie.com.cn, platform/broadcom/sonic-platform-modules-ruijie/b6510-48vs8cq/sonic_platform/fan_drawer.py:70: return self._fan_list[self._index].get_status_led(color)
@jleveque

@jleveque
Copy link
Contributor

jleveque commented Mar 9, 2021

@vboykox: Thanks for catching and fixing!

@jleveque jleveque merged commit c6c81a8 into sonic-net:master Mar 9, 2021
@vboykox vboykox deleted the fix_get_status_led_fan_drawer branch March 9, 2021 18:08
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
Chassisd inside pmon queries asic information from platform modules and stores it into CHASSIS_STATE_DB of redis_chassis.

The reason we keep information in CHASSIS_STATE_DB because it's accessible by swss containers.

Asic information includes asic pci address, module name, and asic id in the module. For example, CHASSIS_STATE_DB will look like below:

127.0.0.1:6379[6]> HGETALL "CHASSIS_ASIC_TABLE|ASIC0"
1) "asic_pci_address"
2) "0000:09:00.0"
3) "module_name"
4) "FABRIC-CARD0"
5) "asic_id_in_module"
6) "0"
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
Fix a bug coming from PR sonic-net#175 when asic is removed due to card getting offline (before it was online).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants