-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic_eeprom] Add unit test for eeprom_tlvinfo_test #282
Open
bill-nokia
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
bill-nokia:tlvinfo-unit-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
|
||
from queue import Empty | ||
import os | ||
import sys | ||
if sys.version_info.major == 3: | ||
from unittest import mock | ||
else: | ||
import mock | ||
|
||
from sonic_eeprom import eeprom_base | ||
from sonic_eeprom import eeprom_tlvinfo | ||
|
||
""" test_eeprom output: | ||
TlvInfo Header: | ||
Id String: TlvInfo | ||
Version: 1 | ||
Total Length: 177 | ||
TLV Name Code Len Value | ||
-------------------- ---- --- ----- | ||
Product Name 0x21 11 7215 IXS-T1 | ||
Part Number 0x22 14 3HE16794AARA01 | ||
Serial Number 0x23 11 NK203110020 | ||
Base MAC Address 0x24 6 50:E0:EF:51:27:91 | ||
Manufacture Date 0x25 19 08/24/2020 16:25:29 | ||
Platform Name 0x28 26 armhf-nokia_ixs7215_52x-r0 | ||
ONIE Version 0x29 45 2019.11-onie_version-nokia_ixs7215_52x-v1.5.1 | ||
MAC Addresses 0x2A 2 64 | ||
Service Tag 0x2F 10 0000000000 | ||
Vendor Extension 0xFD 7 | ||
CRC-32 0xFE 4 0x7E1374C3 | ||
|
||
(checksum valid) """ | ||
|
||
tests_dir = os.path.dirname(os.path.abspath(__file__)) | ||
eeprom_path = os.path.join(tests_dir, 'test_eeprom') | ||
|
||
class TestEEpromTlvInfo: | ||
def test_eeprom(self): | ||
tlvInfo = eeprom_tlvinfo.TlvInfoDecoder(eeprom_path, 0, "", True) | ||
e = tlvInfo.read_eeprom_bytes(256) | ||
tlvInfo.decode_eeprom(e) | ||
|
||
assert(tlvInfo.p == eeprom_path) | ||
assert(tlvInfo._TLV_DISPLAY_VENDOR_EXT == True) | ||
|
||
assert(tlvInfo.is_valid_tlvinfo_header(e) == True) | ||
(tf, crc) = tlvInfo.is_checksum_valid(e) | ||
assert(tf == True) | ||
|
||
(tf, s) = tlvInfo.get_tlv_field(e, tlvInfo._TLV_CODE_PRODUCT_NAME) | ||
assert(tf == True) | ||
assert(s[2].decode() == "7215 IXS-T1") | ||
|
||
(tf, s) = tlvInfo.get_tlv_field(e, tlvInfo._TLV_CODE_PART_NUMBER) | ||
assert(tf == True) | ||
assert(s[2].decode() == "3HE16794AARA01") | ||
|
||
assert(tlvInfo.base_mac_addr(e) == "50:E0:EF:51:27:91") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume MAC address is configured per device. So it cannot always be 50:E0:ED:51:27:91, right? How come platform name is not tested? |
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is common code, pleas do not assume your product name on line 52 and part number on line 56.