Support get_port_or_cage_type #288
Merged
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API returns the masks of all types of port or cage that can be supported on the port All the types are defined in sfp_base.SfpBase Signed-off-by: Stephen Sun <stephens@nvidia.com>
This was referenced Jul 4, 2022
liat-grozovik
previously approved these changes
Jul 6, 2022
|
@prgeor could you please help to review? |
Signed-off-by: Stephen Sun <stephens@nvidia.com>
prgeor
approved these changes
Jul 8, 2022
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Jul 28, 2022
* Support get_port_or_cage_type The API returns the masks of all types of port or cage that can be supported on the port All the types are defined in sfp_base.SfpBase Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add comments to explain the types Signed-off-by: Stephen Sun <stephens@nvidia.com>
Arista-Jenkins
pushed a commit
to aristanetworks/sonic
that referenced
this pull request
Aug 26, 2022
This new API method was introduced by sonic-net/sonic-platform-common#288 Change-Id: Ic04496089c0d6767210ae86320ee4fee38fe17c0
Arista-Jenkins
pushed a commit
to aristanetworks/sonic
that referenced
this pull request
Aug 24, 2023
This new API method was introduced by sonic-net/sonic-platform-common#288 Change-Id: Ic04496089c0d6767210ae86320ee4fee38fe17c0
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API returns the masks of all types of port or cage that can be supported on the port
All the types are defined in sfp_base.SfpBase
Currently, the API is used to check whether a port is an
RJ45port so we suggest supporting it at least forRJ45portsSigned-off-by: Stephen Sun stephens@nvidia.com
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)