Add base class implementation for local users' passwords reset #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
d933770 to
e413c77
Compare
|
|
azmy98
force-pushed
the
dev-reset-local-users-password
branch
2 times, most recently
from
5e3015b to
b147a91
Compare
dgsudharsan
suggested changes
May 14, 2024
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
b147a91 to
6eba119
Compare
dgsudharsan
approved these changes
May 16, 2024
azmy98
force-pushed
the
dev-reset-local-users-password
branch
5 times, most recently
from
b90f7e8 to
10d9aed
Compare
9 tasks
azmy98
force-pushed
the
dev-reset-local-users-password
branch
from
10d9aed to
1aa67f1
Compare
qiluo-msft
reviewed
Sep 24, 2024
| This method is used to reset the user's password and expire it (optional) using Linux shell commands. | ||
| ''' | ||
| # Use 'chpasswd' shell command to change password | ||
| subprocess.call([f"echo '{user}:{hashed_password}' | sudo chpasswd -e"], shell=True) |
There was a problem hiding this comment.
Do not concat command line. It is vulnerable to command argument injection. For example, hashed_password may include blank char.
There was a problem hiding this comment.
Suggest not to use shell=True, instead use shell=False with an array of strings
There was a problem hiding this comment.
It did not work, the quotations are not working correctly when I split it into list and the pipe does not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added base class implementation for local-users-passwords-reset feautre.
Motivation and Context
It defines the abstract class the vendor needs to implement for local-users-passwords-reset feature
How Has This Been Tested?
By inheriting from this base class