[syseepromd] Add unit tests; Refactor to allow for greater unit test coverage #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jleveque
changed the title
…low for better unit test coverage
lguohan
approved these changes
Apr 8, 2021
4 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 9, 2021
Unit tests for syseepromd depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#156
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 10, 2021
Unit tests for syseepromd depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#156
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Unit tests for syseepromd depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#156
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Unit tests for syseepromd depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#156
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Change sffbase.py code to make it compatible with python3 1. change iteritems to items 2. change type(*) = types.* to type(*) = $typename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit test coverage increases from 0% to 90%:
Motivation and Context
To increase unit test coverage >= 90% in order to prevent regressions
How Has This Been Tested?
The refactored psud has been tested on a physical DUT and the unit test results can be examined via the Azure Pipelines check builds in this PR.