Moving pcied service into sonic-host-services, part #1 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaratGubaiev please fix the error. I think you need to remove the sonic_pcied from https://github.com/Azure/sonic-platform-daemons/blob/master/azure-pipelines.yml |
@sujinmkang Done. Maybe you know how to fix this problem: sonic-net/sonic-buildimage#9285 (comment) |
|
@MaratGubaiev What is the intention to move pcied to host service? |
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
PR sonic-net#221 added retry logic to the simualted y_cable driver and introduced typos. This change is to fix the typos. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing sonic-net/sonic-buildimage#7282
See sonic-net/sonic-buildimage#9285
NOTE Tests failing is normal because it should be testes with the changes in sonic-buildimage.Description
pcied removed from sonic-platform-daemons (pmon container)
WARNING it should be merged with coupled changes in sonic-buildimage!
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)