[CMIS] Skip re-init flow for SW-controlled ports in case of fastboot #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
prgeor
reviewed
Jun 7, 2024
sonic-xcvrd/xcvrd/xcvrd.py
Outdated
| # Force DataPath re-init | ||
| api.tx_disable_channel(media_lanes_mask, True) | ||
| if is_fast_reboot and self.check_datapath_state(api, host_lanes_mask, ['DataPathActivated']): | ||
| self.log_notice("{} Skip re-init flow".format(lport)) |
There was a problem hiding this comment.
@stepanblyschak please add "Skip datapath re-init in fast-reboot" log
There was a problem hiding this comment.
@prgeor Done
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
@prgeor Please add "Request for 202405" label, it should cherry-pick without issues |
prgeor
approved these changes
Jun 10, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Jun 12, 2024
…onic-net#497) * [CMIS] Skip re-init flow for SW-controlled ports in case of fastboot Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com> * Change the log message Signed-off-by: Stepan Blyschak <stepanb@nvidia.com> --------- Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com> Signed-off-by: Stepan Blyschak <stepanb@nvidia.com> Co-authored-by: vadymhlushko-mlnx <vadymh@nvidia.com>
|
Cherry-pick PR to 202405: #499 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 12, 2024
…497) * [CMIS] Skip re-init flow for SW-controlled ports in case of fastboot Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com> * Change the log message Signed-off-by: Stepan Blyschak <stepanb@nvidia.com> --------- Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com> Signed-off-by: Stepan Blyschak <stepanb@nvidia.com> Co-authored-by: vadymhlushko-mlnx <vadymh@nvidia.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip the re-init flow for the SW-controlled ports in case of fastboot.
Because during fastboot the switch didn't reset the modules, so there is no need to reinitialize them.
Motivation and Context
To improve the fastboot data-plane disruption time.
How Has This Been Tested?
Run the sonic-mgmt/tests/platform_tests/test_advanced_reboot.py::test_fast_reboot
Additional Information (Optional)