[VOQ][saidump] Enhance saidump with new option -r to parser the JSON file and displays/format the right output, fix compiling error #1335, to fix dpkg-checkbuilddeps: error #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
kcudnik
approved these changes
Feb 6, 2024
|
@kcudnik, there still was some errors: 
What's the reason? Please help to review them. |
|
@kcudnik @mlok-nokia , please help to process the Azure Pipelines / Azure.sonic-sairedis (Test vstest) error. Thanks. |
1 similar comment
|
@kcudnik @mlok-nokia , please help to process the Azure Pipelines / Azure.sonic-sairedis (Test vstest) error. Thanks. |
|
@kcudnik Please help to take a look if these failures is related to the change in this PR? Thanks |
kcudnik
approved these changes
Feb 13, 2024
|
You can ignore this error not related to pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
During the process of fix PR1335,
#1335
There was an error:
dpkg-checkbuilddeps: error: Unmet build dependencies: nlohmann-json3-dev.
I checked the building scripts and found that they didn't include nlohmann-json3-dev. So, I think I need to create a separate PR that only installs nlohmann-json3-dev. After merging that PR, the PR1335 could be checked successfully.
sudo apt-get install -y libxml-simple-perl
aspell
... ...
libjansson-dev
python
How I did it