Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. #472

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/inc/sai_redis.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void check_notifications_pointers(

// if we don't receive response from syncd in 60 seconds
// there is something wrong and we should fail
#define GET_RESPONSE_TIMEOUT (6*60*1000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi i remember that this was changed on purpose but i cant remember why ;/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Let us face it again. If we face, I would prefer to fix the other end.

#define GET_RESPONSE_TIMEOUT (60*1000)

extern std::string getSelectResultAsString(int result);
extern void clear_local_state();
Expand Down