Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gearbox] startup gbsyncd in sync mode in vSonic #939

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[gearbox] startup gbsyncd in sync mode in vSonic #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion syncd/scripts/gbsyncdmgrd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def physyncd_spawn(gearbox_config):
proc_list = []

for i, phy in enumerate(gearbox_config['phys'], 1):
cmd = '/usr/bin/syncd -p /etc/sai.d/pai.profile -x /usr/share/sonic/hwsku/context_config.json -g {}"'.format(i)
cmd = '/usr/bin/syncd -s -p /etc/sai.d/pai.profile -x /usr/share/sonic/hwsku/context_config.json -g {}'.format(i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think -s is deprecated and -z should be used instead.
https://github.com/Azure/sonic-sairedis/blob/40e9c745aa3cfb75dbff91973d2b6dff1e3b61fb/syncd/CommandLineOptionsParser.cpp#L39

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. The option -s is equative to -z redis_sync, which is still used in syncd and orchagent command line parameter.

proc = subprocess.Popen(cmd.split(), close_fds=True)
proc_list.append(proc)
syslog.syslog(syslog.LOG_INFO, 'Spawned PID {}'.format(proc.pid))
Expand Down