Fix review comment

sonic-net · Jan 21, 2022 · 9e39e72 · 9e39e72
1 parent 564ef4a
commit 9e39e72
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/orchagent/intfsorch.cpp b/orchagent/intfsorch.cpp
@@ -1272,8 +1272,8 @@ void IntfsOrch::addIp2MeRoute(sai_object_id_t vrf_id, const IpPrefix &ip_prefix)
     {
         gCrmOrch->incCrmResUsedCounter(CrmResourceType::CRM_IPV6_ROUTE);
     }
-    IpPrefix prefix = ip_prefix.getIp().to_string();
-    gRouteOrch->onAddOtherRouteEntry(vrf_id, prefix);
+
+    gRouteOrch->onAddOtherRouteEntry(vrf_id, IpPrefix(ip_prefix.getIp().to_string()));
 }
 
 void IntfsOrch::removeIp2MeRoute(sai_object_id_t vrf_id, const IpPrefix &ip_prefix)
@@ -1303,8 +1303,8 @@ void IntfsOrch::removeIp2MeRoute(sai_object_id_t vrf_id, const IpPrefix &ip_pref
     {
         gCrmOrch->decCrmResUsedCounter(CrmResourceType::CRM_IPV6_ROUTE);
     }
-    IpPrefix prefix = ip_prefix.getIp().to_string();
-    gRouteOrch->onRemoveOtherRouteEntry(vrf_id, prefix);
+
+    gRouteOrch->onRemoveOtherRouteEntry(vrf_id, IpPrefix(ip_prefix.getIp().to_string()));
 }
 
 void IntfsOrch::addDirectedBroadcast(const Port &port, const IpPrefix &ip_prefix)

diff --git a/orchagent/routeflowcounterorch.cpp b/orchagent/routeflowcounterorch.cpp
@@ -40,9 +40,9 @@ void RouteFlowCounterOrch::doTask(Consumer &consumer)
     {
         KeyOpFieldsValuesTuple t = it->second;
 
-        string key =  kfvKey(t);
-        string op = kfvOp(t);
-        auto data = kfvFieldsValues(t);
+        const auto &key =  kfvKey(t);
+        const auto &op = kfvOp(t);
+        const auto &data = kfvFieldsValues(t);
         if (op == SET_COMMAND)
         {
             size_t maxMatchCount = ROUTE_PATTERN_DEFAULT_MAX_MATCH_COUNT;