Unsupported drop counter types/drop reasons cause syncd to crash with bcm SAI #1136
Assignees
Labels
Comments
lguohan
pushed a commit
that referenced
this issue
Jan 26, 2020
…asons (#1173) - Refactor drop reason capability query to trim SAI prefixes - Store device capabilities in orchagent to perform safety checks Fixes #1136 - Rather than depending on each ASIC vendor to follow the same error handling doctrine, this PR validates HW support in orchagent, which should be more reliable. Related to sonic-net/sonic-utilities#785 - In order to validate user input, we need to remove the SAI prefixes before we store the results. This removes the need for the CLI to perform these checks. Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan
pushed a commit
that referenced
this issue
Jan 28, 2020
…asons (#1173) - Refactor drop reason capability query to trim SAI prefixes - Store device capabilities in orchagent to perform safety checks Fixes #1136 - Rather than depending on each ASIC vendor to follow the same error handling doctrine, this PR validates HW support in orchagent, which should be more reliable. Related to sonic-net/sonic-utilities#785 - In order to validate user input, we need to remove the SAI prefixes before we store the results. This removes the need for the CLI to perform these checks. Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan
pushed a commit
that referenced
this issue
Jan 30, 2020
…asons (#1173) - Refactor drop reason capability query to trim SAI prefixes - Store device capabilities in orchagent to perform safety checks Fixes #1136 - Rather than depending on each ASIC vendor to follow the same error handling doctrine, this PR validates HW support in orchagent, which should be more reliable. Related to sonic-net/sonic-utilities#785 - In order to validate user input, we need to remove the SAI prefixes before we store the results. This removes the need for the CLI to perform these checks. Signed-off-by: Danny Allen <daall@microsoft.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this issue
Feb 28, 2022
…-net#1136) * [config/console] Support add/del console port setting commands * Add new console.py file to support config console commands * Add UTs for console.py
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this issue
Mar 1, 2023
* Fixing issue #11621 * The cleanup code for stale rif counters are now moved to syncd . Earlier as part of fix for issue sonic-net#2193 the cleanup for stale rif counters was added. * But it could create a race condition between orchagent removes RIF rate counters from DB and lua script fetching them. * So as a fix all such cleanup has been moved to syncd. Signed-off-by: Suman Kumar <suman.kumar@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Attempting to create a drop counter with an unsupported type or with unsupported drop reasons will cause syncd to crash on Broadcom devices. (Note: This is only possible if you attempt to modify Config DB directly - the CLI will prevent users from pushing a bad config in the first place.)
This is a known issue and we're working with Broadcom to resolve it.
The text was updated successfully, but these errors were encountered: