Adopt to signature change of Selectable::readData #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return type from void to uint64_t.
renukamanavalan
requested review from
lguohan,
jleveque,
pavel-shirshov and
yxieca
jleveque
approved these changes
Sep 18, 2019
|
This PR will not build until swss-common changes are committed and this build picks the latest swss-common. |
yxieca
approved these changes
Sep 19, 2019
|
retest this please. |
stcheng
approved these changes
Sep 19, 2019
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
The import re line was removed from the file in sonic-net#953. However, it is still referenced in the update_sonic_environment() function. Adding it back.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* Add Voqs to Virtual Switch * Add UnitTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which switched return type from void to uint64_t.
What I did
Why I did it
How I verified it
Details if related